Write multi-level datasets #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 30 30
Lines 1458 1458
=======================================
Hits 1457 1457
Misses 1 1 ☔ View full report in Codecov by Sentry. |
|
I am missing the possibility to :
another case, but currently not urgent:
|
AliceBalfanz
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Works nicely! Thank you for the implementation!
I am missing two things in the documentation:
- To inform the user, that write levels is not as robust as zappend itself. There will be a corrupt levels if an interruption happens during the process
- Make the user aware of the need to remove bnds when leveling.
Do you think it is worth adding the above information? Not sure where the right place would be, maybe the changelog?
Yes! |
The function's docstring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added experimental function
zappend.levels.write_levels()that generates datasets using the multi-level dataset format as specified by xcube.It resembles the
store.write_data(cube, "<name>.levels", ...)method provided by the xcube filesystem data stores ("file", "s3", "memory", etc.). The zappend version may be used for potentially very large datasets in terms of dimension sizes or for datasets with very large number of chunks. It is considerably slower than the xcube version (which basically usesxarray.to_zarr()for each resolution level), but should run robustly with stable memory consumption. The function requiresxcubepackage to be installed.Addresses #19.
Checklist (strike out non-applicable):
CHANGES.mdCHANGES.mddocs/*